Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: BitVec.signExtend_eq_append_extractLsb' #7454

Merged
merged 5 commits into from
Mar 12, 2025
Merged

feat: BitVec.signExtend_eq_append_extractLsb' #7454

merged 5 commits into from
Mar 12, 2025

Conversation

bollu
Copy link
Contributor

@bollu bollu commented Mar 12, 2025 •
edited
Loading

This PR implements the bitwuzla rule BV_SIGN_EXTEND_ELIM, which rewrites a signExtend x as an append of the appropriate sign bits, followed by the bits of x.

@bollu bollu requested a review from kim-em as a code owner March 12, 2025 10:45
@bollu
Copy link
Contributor Author

bollu commented Mar 12, 2025

changelog-library

@github-actions github-actions bot added the changelog-library Library label Mar 12, 2025
alexkeizer
alexkeizer reviewed Mar 12, 2025
View reviewed changes
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 12, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase eb58f46ce7b41a9b6b273bb2dae2dc11abd78246 --onto 8fc8e8ed19ef218022f5a94cbf5e472e3b777e44. You can force Mathlib CI using the force-mathlib-ci label. (2025-03-12 11:16:07)

@alexkeizer
Copy link
Contributor

alexkeizer commented Mar 12, 2025 •
edited
Loading

LGTM!

@alexkeizer
Copy link
Contributor

Just pushed a commit with my last suggestion, once again, the PR LGTM

@bollu
Copy link
Contributor Author

bollu commented Mar 12, 2025

Note that the symmetric version with v ≤ w is available as

theorem signExtend_eq_setWidth_of_lt (x : BitVec w) {v : Nat} (hv : v ≤ w) :
  x.signExtend v = x.setWidth v := signExtend_eq_setWidth_of_le x hv

@hargoniX hargoniX added this pull request to the merge queue Mar 12, 2025
Merged via the queue into leanprover:master with commit 8850f9e Mar 12, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasgrosser tobiasgrosser tobiasgrosser approved these changes

@alexkeizer alexkeizer alexkeizer left review comments

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

Assignees
No one assigned
Labels
changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bollu @leanprover-community-bot @alexkeizer @tobiasgrosser @hargoniX