Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix content offset value #1091

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix content offset value #1091

wants to merge 1 commit into from

Conversation

kyle-ssg
Copy link

Is it a bugfix ?

Describe what you've done:

The contentOffset was looking inside state rather than this.internals, where the offset is adjusted. This means as soon as setState is called the offset resets.

How to test it ?

Create a swiper with 2 slides, swipe to slide 2 and then trigger a setState.

@0kzh
Copy link

0kzh commented Jun 11, 2020

Can we please merge this? This PR has been out for a long time and fixes a breaking bug on iOS devices.

@kyle-ssg
Copy link
Author

Hate to admit it but unless this repo gets transferred to react-native-community I'd consider it dead.

@xiaowu2333
Copy link

very good

@HeidiAshraf
Copy link

Thank you

1 similar comment
@marlti7
Copy link

marlti7 commented Mar 8, 2022

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants