Fix content offset value #1091
Open
Fix content offset value #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we please merge this? This PR has been out for a long time and fixes a breaking bug on iOS devices. |
|
Hate to admit it but unless this repo gets transferred to react-native-community I'd consider it dead. |
|
very good |
|
Thank you |
1 similar comment
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is it a bugfix ?
Describe what you've done:
The contentOffset was looking inside state rather than this.internals, where the offset is adjusted. This means as soon as setState is called the offset resets.
How to test it ?
Create a swiper with 2 slides, swipe to slide 2 and then trigger a setState.