Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes offset miscalculation bug #1127

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

sethcwhiting
Copy link

Is it a bugfix ?

  • Yes or No ?
  • If yes, which issue (fix #number) ?

Yes. Issue #1060

Is it a new feature ?

  • Yes or no ?
  • Include documentation, demo GIF if applicable

No.

Describe what you've done:

I've updated this.internals to include the offset value updated directly above.

How to test it ?

When you scrolling to the last child, append one more to the list. Without the updated code, scrolling to the newly appended child behaves erratically. This code makes the behavior more predictable.

@maulikdhameliya
Copy link

@sethcwhiting you did a great job fixing this. This patch is needed when dynamically your swiper data size is increasing or decreasing.

@sethcwhiting sethcwhiting requested a review from arribbar January 27, 2020 12:19
@eitanfr
Copy link

eitanfr commented Apr 5, 2020

Hi,
Does this fix planned to be merged at any time soon?

@josewhitetower
Copy link

Any update on this please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants