Fixes offset miscalculation bug #1127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sethcwhiting you did a great job fixing this. This patch is needed when dynamically your swiper data size is increasing or decreasing. |
|
Hi, |
|
Any update on this please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is it a bugfix ?
Yes. Issue #1060
Is it a new feature ?
No.
Describe what you've done:
I've updated this.internals to include the offset value updated directly above.
How to test it ?
When you scrolling to the last child, append one more to the list. Without the updated code, scrolling to the newly appended child behaves erratically. This code makes the behavior more predictable.