Ensure internals.offset has a default value onLayout #537
+21
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arribbar
reviewed
Sep 8, 2017
| return Object.assign({}, this.state, this.internals) | ||
| } | ||
|
|
||
| onLayout = (event) => { | ||
| const { width, height } = event.nativeEvent.layout | ||
| const offset = this.internals.offset = {} | ||
| const offset = this.internals.offset = { x: 0, y: 0 } |
There was a problem hiding this comment.
You should be able to add it to internals var line 228, shouldn't you ?
There was a problem hiding this comment.
So I realize I'm... 2 years late; did we fix this? lol
There was a problem hiding this comment.
It doesn't work right. Should be so
const offset = this.internals.offset = { x: width, y: height }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is it a bugfix ?
Is it a new feature ?
Describe what you've done:
Ensured that
internals.offsethas a default value inonLayout. This could be implemented somehow in theinitStatemethod, but I'm not familiar enough with what's happening in there.How to test it ?
Verify that a
Swipercomponent changes it's index appropriately on swipe.