Import from the httpx public API.
#232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of changes here to start to make sure that authlib only imports from the httpx public API...
Request/Responsefrom the top-level API.httpx.AsyncClient(app=...)instead of relying on the undocumented dispatch API.I still need to look at the usage of the ContentStreams API and figure out if https://github.com/encode/httpx/pull/932/files is the right approach, or if there's already sufficient public API here, and the auth flow just need re-jigging.
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
(If no, please delete the above question and this text message.)