Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SA/ARI: Add method of tracking certificate replacement #7284

Merged
merged 10 commits into from
Feb 8, 2024

Conversation

beautifulentropy
Copy link
Member

@beautifulentropy beautifulentropy commented Jan 26, 2024

Part of #6732
Part of #7038

Copy link
Contributor

@beautifulentropy, this PR appears to contain configuration changes. Please ensure that a corresponding deployment ticket has been filed with the new configuration values.

@beautifulentropy beautifulentropy force-pushed the sa-replacement-orders branch 4 times, most recently from 69ff0dd to 5a880fb Compare January 27, 2024 00:25
@beautifulentropy beautifulentropy marked this pull request as ready for review January 27, 2024 00:32
@beautifulentropy beautifulentropy requested a review from a team as a code owner January 27, 2024 00:32
@pgporada pgporada requested a review from a team January 30, 2024 15:26
@pgporada
Copy link
Member

You'll need to fix the spelling errors found by typos and regenerate the protobufs because of the comment change.

@beautifulentropy beautifulentropy marked this pull request as draft January 31, 2024 18:39
@beautifulentropy
Copy link
Member Author

Converting to draft while I make some changes to the schema.

@beautifulentropy beautifulentropy marked this pull request as ready for review January 31, 2024 21:57
Copy link
Contributor

@aarongable aarongable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Primary logic LGTM. We're missing unit tests for the new functions in model.go. In particular, I think it's important to have tests for

  • addReplacementOrder working in both the normal and the already-exists cases; and
  • setReplacementOrderFinalized working both when there's a row to update and when there isn't one.

@beautifulentropy
Copy link
Member Author

Primary logic LGTM. We're missing unit tests for the new functions in model.go. In particular, I think it's important to have tests for

  • addReplacementOrder working in both the normal and the already-exists cases; and
  • setReplacementOrderFinalized working both when there's a row to update and when there isn't one.

I'm pretty sure that I've got coverage for these cases in the existing SA unit test. I'd happily break that out into the model.go test explicitly though.

aarongable
aarongable previously approved these changes Feb 5, 2024
Copy link
Contributor

@aarongable aarongable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think it'd be much clearer to have individual tests for addReplacementOrder and setReplacementOrderFinalized.

aarongable
aarongable previously approved these changes Feb 7, 2024
@beautifulentropy beautifulentropy merged commit f10abd2 into main Feb 8, 2024
19 checks passed
@beautifulentropy beautifulentropy deleted the sa-replacement-orders branch February 8, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants