-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove gogo protobuf #60
Conversation
ca3fb23
to
8bc0539
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to consider downstream consumers who are probably still using gogo with the generated code, which are likely to break.
So if you want to kill gogo, you have to do it in the consumers as well, and this quickly becomes quite a large project in itself.
Note: I am not suggesting that we should keep gogo, by all means it is deprecated and we should move away from it, just pointing out that it is not trivial.
8bc0539
to
26aae8f
Compare
Yes, I am moving go-libp2p-kad-dht away from gogo, and there is a dependency on go-libp2p-record. The plan is to make a new release of go-libp2p-record so that consumers can move away from gogo when they are ready. |
Why would downstream consumers be impacted? They just use the generated file, no? |
there might be some api changes. |
The api changes are just that Marshal/Unmarshal are not methods on the generated structs, but instead functions that use reflect in the proto package. It's also missing the Should be a relatively straightforward change when upgrading. |
Gogo protobuf is deprecated. Move away from it.
Also updated dependencies.