Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gogo protobuf #60

Merged
merged 4 commits into from
Jan 17, 2025
Merged

Remove gogo protobuf #60

merged 4 commits into from
Jan 17, 2025

Conversation

guillaumemichel
Copy link
Contributor

@guillaumemichel guillaumemichel commented Aug 7, 2024

Gogo protobuf is deprecated. Move away from it.

Also updated dependencies.

@guillaumemichel guillaumemichel force-pushed the fix/deprecate-gogo branch 2 times, most recently from ca3fb23 to 8bc0539 Compare August 7, 2024 13:23
Copy link

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to consider downstream consumers who are probably still using gogo with the generated code, which are likely to break.

So if you want to kill gogo, you have to do it in the consumers as well, and this quickly becomes quite a large project in itself.

Note: I am not suggesting that we should keep gogo, by all means it is deprecated and we should move away from it, just pointing out that it is not trivial.

@guillaumemichel
Copy link
Contributor Author

Yes, I am moving go-libp2p-kad-dht away from gogo, and there is a dependency on go-libp2p-record. The plan is to make a new release of go-libp2p-record so that consumers can move away from gogo when they are ready.

@sukunrt
Copy link
Member

sukunrt commented Jan 16, 2025

@vyzo

you need to consider downstream consumers who are probably still using gogo with the generated code, which are likely to break.

Why would downstream consumers be impacted? They just use the generated file, no?

@vyzo
Copy link

vyzo commented Jan 16, 2025

there might be some api changes.

@MarcoPolo
Copy link

The api changes are just that Marshal/Unmarshal are not methods on the generated structs, but instead functions that use reflect in the proto package. It's also missing the MarshalTo(SizedBuffer) method.

Should be a relatively straightforward change when upgrading.

@guillaumemichel guillaumemichel merged commit f04da83 into master Jan 17, 2025
9 checks passed
@guillaumemichel guillaumemichel deleted the fix/deprecate-gogo branch January 17, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants