Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(holepunch/tracer): replace inline peer struct with peerInfo type #3049

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix(holepunch/tracer): replace inline peer struct with peerInfo type #3049

merged 1 commit into from
Nov 19, 2024

Conversation

cpeliciari
Copy link
Contributor

@cpeliciari cpeliciari commented Nov 19, 2024 •
edited by MarcoPolo
Loading

  • Introduced the peerInfo struct to encapsulate peer metadata.
  • Updated the peers map in the tracer struct to use peerInfo.
  • Simplified code by avoiding inline struct definition for peers.

@cpeliciari
refactor: replace inline peer struct with peerInfo type
a04ff02 
- Introduced the `peerInfo` struct to encapsulate peer metadata.
- Updated the `peers` map in the `tracer` struct to use `peerInfo`.
- Simplified code by avoiding inline struct definition for peers.
@MarcoPolo MarcoPolo changed the title fix: replace inline peer struct with peerInfo type fix(holepunch): replace inline peer struct with peerInfo type Nov 19, 2024
@MarcoPolo MarcoPolo changed the title fix(holepunch): replace inline peer struct with peerInfo type fix(holepunch/tracer): replace inline peer struct with peerInfo type Nov 19, 2024
@MarcoPolo MarcoPolo merged commit cb14acf into libp2p:master Nov 19, 2024
8 of 9 checks passed
@MarcoPolo
Copy link
Collaborator

thanks!

@interbattles interbattles mentioned this pull request Nov 24, 2024
Closed
ethan-gallant added a commit to ethan-gallant/go-libp2p that referenced this pull request Dec 16, 2024
@ethan-gallant
Revert "fix(holepunch/tracer): replace inline peer struct with peerIn…
365a3d1 
…fo type (libp2p#3049)"

This reverts commit cb14acf.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoPolo MarcoPolo MarcoPolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpeliciari @MarcoPolo