This repository was archived by the owner on Feb 26, 2021. It is now read-only.
fix: ensure all addresses are multiaddr #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| exports = module.exports = Peer | ||
|
|
||
| function ensureMultiaddr (addr) { | ||
| if (addr instanceof multiaddr) { |
There was a problem hiding this comment.
This will fail in times there is a version difference. I know that ideally we have the latest version of multiaddr everywhere, but we can't be 100% sure of that. Would be better to do duck typing.
There was a problem hiding this comment.
How about we add Multiaddr.isMultiaddr to the multiaddr module?
There was a problem hiding this comment.
|
@dignifiedquire thank you :) Other than the |
|
@dignifiedquire could you rebase and finish up this PR? Thank you |
dignifiedquire
force-pushed
the
fix/multiaddr
branch
from
aa9e50e to
a89f221
Compare
dignifiedquire
force-pushed
the
fix/multiaddr
branch
from
a89f221 to
2cfac63
Compare
|
@diasdavid ready once the referenced PR is merged and released |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.