This repository was archived by the owner on Oct 10, 2018. It is now read-only.
docs: bring the spec to the spec repo #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddias
added a commit
to daviddias/go-multiplex
that referenced
this pull request
Feb 19, 2018
Moved it to libp2p/mplex#1
This was referenced Feb 19, 2018
|
|
||
| ``` | ||
| header = readUvarint() | ||
| flag = head & 0x07 |
There was a problem hiding this comment.
Should be header & 0x07
There was a problem hiding this comment.
Thanks for the review @richardschneider. This was a straight c&p from @Stebalien's notes. Mind submitting a PR with the proposed fixes?
| ``` | ||
| header = readUvarint() | ||
| flag = head & 0x07 | ||
| id = flag >> 3 |
There was a problem hiding this comment.
should header >> 3
| | CloseReceiver | 3 | | ||
| | CloseInitiator | 4 | | ||
| | ResetReceiver | 5 | | ||
| | ResetInitiator | 6 | |
There was a problem hiding this comment.
Not displaying correctly. Try adding a header to the table, e.g. | Flag | Value| \n | ---- | ------ |
There was a problem hiding this comment.
I fixed it in master. ca1d70a
|
|
||
| The data segment is length prefixed by another unsigned varint. This results in one message looking like: | ||
|
|
||
| | header | length | data | |
There was a problem hiding this comment.
Again a header with | ---- | ---- | ---- |
There was a problem hiding this comment.
Fixed in master ca1d70a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
//cc @Stebalien