feat(identity): make secp256k1::SecretKey::sign
infallible
#3850
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, this function would return an error in case the provided digest is not of 32 bytes long. As per our spec, we hash all messages with SHA256 before signing, thus this error can never happen in practice.
This brings us one step closer to an infallible
Keypair::sign
which is now only fallible due to RSA signing. If we manage to fix that as well, constructors likenoise::Config::new
will become infallible.Notes & open questions
Change checklist