Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typos #5079

Merged
merged 10 commits into from
Feb 22, 2024
Merged

chore: fix typos #5079

merged 10 commits into from
Feb 22, 2024

Conversation

Thabokani
Copy link
Contributor

@Thabokani Thabokani commented Jan 12, 2024

Description

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger changed the title Fix: typos docs: fix typos Jan 13, 2024
thomaseizinger
thomaseizinger previously approved these changes Jan 13, 2024
@thomaseizinger thomaseizinger changed the title docs: fix typos chore: fix typos Jan 21, 2024
@mergify mergify bot dismissed thomaseizinger’s stale review January 21, 2024 17:27

Approvals have been dismissed because the PR was updated after the send-it label was applied.

thomaseizinger
thomaseizinger previously approved these changes Jan 24, 2024
@drHuangMHT
Copy link
Contributor

@thomaseizinger Stalled for cargo deny error

@mergify mergify bot dismissed thomaseizinger’s stale review February 12, 2024 01:09

Approvals have been dismissed because the PR was updated after the send-it label was applied.

@drHuangMHT
Copy link
Contributor

Are we not resolving dependency issue very soon? I'm seeing some MAJOR version bumps in cargo deny and recent tests kept failing. @thomaseizinger

@thomaseizinger
Copy link
Contributor

Are we not resolving dependency issue very soon? I'm seeing some MAJOR version bumps in cargo deny and recent tests kept failing. @thomaseizinger

Mergify is somehow broken and I don't have the resources to fix it unfortunately. Help is much appreciated!

Perphaps we should also move to GitHub's merge queue.

@jxs jxs added send-it and removed send-it labels Feb 22, 2024
@mergify mergify bot merged commit 580c7db into libp2p:master Feb 22, 2024
71 of 73 checks passed
@jxs
Copy link
Member

jxs commented Feb 22, 2024

may it be that it's just flaky?

guillaumemichel pushed a commit that referenced this pull request Mar 28, 2024
Pull-Request: #5079.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants