Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(websocket): change name convention #5873

Merged

Conversation

shiyasmohd
Copy link
Contributor

Description

From #2217 , Changing WsConfig to Config

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Copy link
Member

@dariusc93 dariusc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Could you update the cargo version in both the crate in workspace and use a type alias with a deprecated message? :)

@shiyasmohd
Copy link
Contributor Author

shiyasmohd commented Feb 19, 2025

@dariusc93 I've already updated cargo version in crate and workspace. In this new commit I've added deprecate msg too.
Please let me know if I'm missing something.

Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jxs jxs added the send-it label Feb 20, 2025
@mergify mergify bot merged commit ce3908f into libp2p:master Feb 20, 2025
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants