Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action Container build and push #9

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Add action Container build and push #9

merged 3 commits into from
Oct 23, 2024

Conversation

mickkael
Copy link
Contributor

it build the container for amd64, armv7 and arm64 and push to ghcr.io registry

it build the container for amd64, armv7 and arm64 and push to ghcr.io registry
@SudoDios
Copy link
Collaborator

Hi @mickkael, thank you.
I just a test this but get this error :
exec /usr/local/bin/librespeed-rs: no such file or directory.
Is the problem with my docker configuration or something else ☺️ ?

@mickkael
Copy link
Contributor Author

Let me check and come back to you. I have tested the container build, but not the container actually

@mickkael
Copy link
Contributor Author

@SudoDios I have found the issue. Actually the binary is not working with alpine for an unknown reason. I will submit a fix later

@SudoDios
Copy link
Collaborator

@mickkael Oh Ok.
Let me know if I can help

@SudoDios
Copy link
Collaborator

@mickkael
I think I found the real problem.
The problem is with glibc, it doesn't exist in alpine, and alpine works with musl.
I just put musl in docker and it worked.
Read this

@mickkael
Copy link
Contributor Author

I made it work with debian base image, but I'll replace with the musl build instead. I'll push a commit soon

@mickkael
Copy link
Contributor Author

I have a working version for alpine/amd64. But it fails to run for arm/aarch. I can't find the good compilation config to make it compatible musl.
I'll push with debian for now, alpine requires more work

@SudoDios
Copy link
Collaborator

Does Debian not have a light version in Docker ?
Why must you work with Alpine ?

@mickkael
Copy link
Contributor Author

Alpine is much much slimmer with fewer packages. Hence it is less prone to vulnerabilities, and is indeed faster to download.
But debian will be ok

@SudoDios
Copy link
Collaborator

Now working on Debian.
But the only problem is its size ? is it true ?
I think we should merge this for now and then it can be improved.
Okay ?

@mickkael
Copy link
Contributor Author

I build and test on amd64 and arm64. I will share the container size

make the binary executable
@mickkael
Copy link
Contributor Author

It's confirmed working on docker on x86_64 and arm64/rpi4.
The container size is 102mb on x86_64 and 118 mb on arm64.
It's good for a merge on my side

@SudoDios
Copy link
Collaborator

Ok, We will do it tomorrow.
Thank you 😊

@SudoDios SudoDios merged commit f8af73a into librespeed:master Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants