Create anchors for pointer-based arguments to initializers #103
Conversation
arik-so
force-pushed
the
init-pointer-anchoring
branch
from
e53c45f to
6eae29b
Compare
arik-so
force-pushed
the
init-pointer-anchoring
branch
from
6eae29b to
d3bcd0b
Compare
| let returnValueHandlingPrefix = ''; | ||
| let returnValueHandlingSuffix = ''; | ||
| if (swiftMethodName === 'init') { | ||
| anchoringCommand = anchoringCommand.replaceAll('returnValue.addAnchor(', 'self.addAnchor(') |
There was a problem hiding this comment.
Can we just define two separate commands instead of reusing this?
There was a problem hiding this comment.
I guess we could, but I do like that this doesn't mess with the indentation.
| @@ -807,6 +815,10 @@ export abstract class BaseTypeGenerator<Type extends RustType> { | |||
| } | |||
| `; | |||
|
|
|||
| if(memoryContext && memoryContext.isConstructor && (argument.type instanceof RustStruct || argument.type instanceof RustTaggedValueEnum || argument.type instanceof RustResult)){ | |||
There was a problem hiding this comment.
Could you add a brief comment here explaining what anchoring is and why we it is required in these cases in particular?
| @@ -1284,6 +1296,11 @@ export interface PreparedArgument { | |||
| * memory deallocation or, ironically, retention beyond the call site | |||
| */ | |||
| deferredCleanup: string | |||
|
|
|||
| /** | |||
| * If true (only applicable in constructors), add a `self.addAnchor` call after super.init() | |||
There was a problem hiding this comment.
IIUC there are however other cases were the anchors are added, not only upon init?
| @@ -301,9 +302,13 @@ public class HumanObjectPeerTestInstance { | |||
| // channel manager constructor is mandatory | |||
|
|
|||
| let graph = NetworkGraph(network: .Regtest, logger: self.logger) | |||
| var scorerGraph = graph | |||
| if(master.configuration.ephemeralNetworkGraphForScorer) { | |||
There was a problem hiding this comment.
nit: Could add some space after if and drop the parentheses.
| @@ -465,6 +465,9 @@ class LDKSwiftTests: XCTestCase { | |||
|
|
|||
| config.useRouter = (i & (1 << 2)) != 0 | |||
| print("useRouter: \(config.useRouter)") | |||
|
|
|||
| config.ephemeralNetworkGraphForScorer = (i & (1 << 3)) != 0 | |||
There was a problem hiding this comment.
nit: May want to add a comment on how these magic shiftings work.
| @@ -465,6 +465,9 @@ class LDKSwiftTests: XCTestCase { | |||
|
|
|||
| config.useRouter = (i & (1 << 2)) != 0 | |||
| print("useRouter: \(config.useRouter)") | |||
|
|
|||
| config.ephemeralNetworkGraphForScorer = (i & (1 << 3)) != 0 | |||
| print("ephemeralNetworkGraphForScorer: \(config.ephemeralNetworkGraphForScorer)") | |||
|
|
|||
| /* | |||
There was a problem hiding this comment.
nit: Can we drop the commented-out code here and above while we're here?
Fixes #102.