LRU block cache #88
Merged
LRU block cache #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it is not only fetching blocks from the network anymore.
Roasbeef
commented
Aug 23, 2018
neutrino.go
Outdated
| @@ -500,6 +500,11 @@ type ChainService struct { | |||
| BlockHeaders *headerfs.BlockHeaderStore | |||
| RegFilterHeaders *headerfs.FilterHeaderStore | |||
|
|
|||
| // queryPeers will be called to send messages to one or more peers, | |||
There was a problem hiding this comment.
This is a good initial start. Ideally in the end we make the set of query methods into an interface so we can easily mock them out if needed. It'll also allow us to test the set of query behavior w/o actually having an active network connection.
cache/cacheable_block.go
Outdated
|
|
||
| // Size returns size of this block in bytes. | ||
| func (c *CacheableBlock) Size() (uint64, error) { | ||
| f, err := c.Block.Bytes() |
There was a problem hiding this comment.
Can instead use SerializeSize here in order to not have to re-encode the entire thing.
query.go
Outdated
| @@ -905,9 +905,21 @@ func (s *ChainService) GetBlockFromNetwork(blockHash chainhash.Hash, | |||
| invType = wire.InvTypeBlock | |||
| } | |||
|
|
|||
| // Create an inv vector for getting this block. | |||
| inv := wire.NewInvVect(invType, &blockHash) | |||
There was a problem hiding this comment.
Why use an inv vector rather than the hash of the block for the cache?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #72, adding an in-memory block cache for block received from peers.
@halseth