sweep: create sweeper #1960
Merged
sweep: create sweeper #1960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
added
enhancement
joostjager
force-pushed
the
sweeper
branch
9 times, most recently
from
5ce7feb to
0e9fbeb
Compare
This was referenced Oct 1, 2018
joostjager
force-pushed
the
sweeper
branch
14 times, most recently
from
369d13b to
58740fd
Compare
|
|
Tested nursery tx migration again. Seems to work on my machine. |
Roasbeef
previously approved these changes
Dec 18, 2018
|
Modifying the static fees is not thread safe. In this commit the fees are made immutable.
We need to distinguish an lnd build for the purpose of integration testing from a regular dev build. This makes it possible to adapt parameters to let integration tests run faster (for example: sweeper batch window).
This commit is a preparation for the implementation of remote spend detection. Remote spends may happen before we broadcast our own sweep tx. This calls for accurate height hints.
This commit adds a function that takes a set of inputs and splits them in sensible sets to be used for generating transactions.
This commit adds a store for the sweeper. The sweeper needs minimal persistent data to be able to recognize its own sweeps.
In this commit, the sweep package is extended from just tx generation to an active sweeper that collects sweep inputs and autonomously proceeds to publish the sweep tx after the batch window time interval has passed without new inputs being added.
Previously, nursery generated and published its own sweep txes. It stored the sweep tx in nursery_store to prevent a new tx with a new sweep address from being generated on restart. In this commit, sweep generation and publication is removed from nursery and delegated to the sweeper. Also the confirmation notification is received from the sweeper.
cfromknecht
approved these changes
Dec 19, 2018
There was a problem hiding this comment.
Awesome work @joostjager, excited to finally have this in and help people sweep their stuck outputs! Very happy with the final iteration and the huge reduction in complexity over the nursery, LGTM 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the sweeper logic from
utxonurseryinto a separate sweeper struct.A follow up PR is #2000, which will let resolvers use the sweeper directly instead of going through nursery. The end goal is to remove nursery completely.
In this PR, there is no db migration to clean up now unused nursery store data. This allows us to keep the downgrade path open for a while.