lnrpc: deprecate SendToRoute with more than one route #2521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
added
rpc
halseth
previously approved these changes
Jan 22, 2019
| @@ -4072,7 +4070,7 @@ func unmarshallHop(graph *channeldb.ChannelGraph, hop *lnrpc.Hop, | |||
|
|
|||
| // unmarshallRoute unmarshalls an rpc route. For hops that don't specify a | |||
| // pubkey, the channel graph is queried. | |||
| func (r *rpcServer) unmarshallRoute(rpcroute *lnrpc.Route, | |||
Roasbeef
requested changes
Feb 1, 2019
| } | ||
|
|
||
| var routes []*routing.Route | ||
| if len(req.Routes) > 0 { |
There was a problem hiding this comment.
Why even distinguish these two cases? If the case of the else statement, it completes after a single loop iteration.
There was a problem hiding this comment.
I chose not to restrict the Routes field to a single element, but to add a new non-list field Route. Therefore the else construct here.
The intention behind this is to make one change to the interface and not two (first restrict to a single element and then later make it a non-list field).
joostjager
force-pushed
the
sendtosingleroute
branch
from
28b9b96 to
3ce228c
Compare
|
ptal @Roasbeef |
joostjager
force-pushed
the
sendtosingleroute
branch
from
3ce228c to
17645fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current SendToRoute RPC call offers the option of passing in multiple routes. Especially in the streaming variant, this makes the structure of the response complicated, because it is double nested (multiple streamed requests each containing multiple routes for each of which a result needs to be reported). The advantage of this in terms of network round trips is negligible, so the proposal is to limit every SendToRoute request to a single route.