rpc: fix regression in SendToRouteSync payment hash parsing #2601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change in this area of the codebase refactored some code to make way for the deprecation of the streaming multi-route `SendToRoute` method. Along the way, it removed the parsing of the `PaymentHashString` field for the sync `SendToRouteSync` which is meant to be used via the REST interface. In this commit, we fix this by populating _both_ `PaymentHash` and `PaymentHashString`. This is OK, as `extractPaymentIntent` will check both values to extract the hex-encoded payment hash if it's specified.
joostjager
approved these changes
Feb 7, 2019
|
This is why github should start to show code only-moved 🙄 |
halseth
approved these changes
Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change in this area of the codebase refactored some code to
make way for the deprecation of the streaming multi-route
SendToRoutemethod. Along the way, it removed the parsing of the
PaymentHashStringfield for the sync
SendToRouteSyncwhich is meant to be used via theREST interface. In this commit, we fix this by populating both
PaymentHashandPaymentHashString. This is OK, asextractPaymentIntentwill check both values to extract the hex-encodedpayment hash if it's specified.