docs: Update minimum golang version to 1.14 #4943
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakesylvestre
force-pushed
the
go1.13-docs
branch
from
37f7319 to
cf22b66
Compare
jakesylvestre
changed the title
Roasbeef
requested changes
Jan 28, 2021
docs/code_contribution_guidelines.md
Outdated
| @@ -572,7 +572,7 @@ Rejoice as you will now be listed as a [contributor](https://github.com/lightnin | |||
|
|
|||
| ## Contribution Checklist | |||
|
|
|||
| - [ ] All changes are Go version 1.12 compliant | |||
| - [ ] All changes are Go version 1.13 compliant | |||
There was a problem hiding this comment.
This should actually be Go 1.14 since we usually support the two latest versions rn: 1.14 and 1.15.
jakesylvestre
force-pushed
the
go1.13-docs
branch
2 times, most recently
from
ac497b8 to
470bea5
Compare
jakesylvestre
changed the title
|
Will undo docker file change. Looks like you changed this in: 578b348 |
jakesylvestre
force-pushed
the
go1.13-docs
branch
from
470bea5 to
82b8ece
Compare
jakesylvestre
commented
Feb 12, 2021
| @@ -1,4 +1,4 @@ | |||
| FROM golang:1.12-alpine as builder | |||
There was a problem hiding this comment.
btw - I'm not sure what's up with githubs diffing here, but this is what's on master
|
Closing in favor of #5034 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, so looks like I missed this in #4438. So btcd now requires go 1.14 as per btcsuite/btcd#1621. I've never touched ltcd, but it is a btcd fork. It looks like their minimum is still go 1.12 so I've left that dockerfile alone for now. I can update this if needed
There's also the matter of ticker and queue which are still at 1.12. I've left these alone for now. Happy to update if needed
Pull Request Checklist
Contribution Guidelines
All changes are Go version 1.12 compliantsee pr descriptionthe positive and negative (error paths) conditions (if applicable)
the bug being fixed to prevent regressions
logging level
go fmtlnrpc/**/*.proto) have been formatted withmake rpc-formatand compiled withmake rpc(the tab character should be counted as 8 characters, not 4, as some IDEs do
per default)
make checkdoes not fail any testsgo vetdoes not report any issuesmake lintdoes not report any new issues that did notalready exist
cases it can be justifiable to violate this condition. In that case, the
reason should be stated in the commit message.