Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add TLSExtraDomain to config #864

Merged
merged 2 commits into from
Mar 20, 2018
Merged

[Feature] Add TLSExtraDomain to config #864

merged 2 commits into from
Mar 20, 2018

Conversation

junderw
Copy link
Contributor

@junderw junderw commented Mar 17, 2018

Self explanatory.

Needed for NodeJS, as the grpc library only allows TLS connections to domains and not IP addresses.

grpc/grpc#2691

@meshcollider meshcollider added the config Parameters/arguments/config file related issues/PRs label Mar 17, 2018
Roasbeef
Roasbeef approved these changes Mar 20, 2018
View reviewed changes
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! We've received a few requests from users to be able to specify a target domain in addition to an additional IP address.

LGTM 🎉

@Roasbeef Roasbeef merged commit 237ed4f into lightningnetwork:master Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roasbeef Roasbeef Roasbeef approved these changes

Assignees
No one assigned
Labels
config Parameters/arguments/config file related issues/PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@junderw @Roasbeef @meshcollider