lncli: new command `wallet estimatefeerate` #8730

feelancer21 · 2024-05-05T21:36:46Z

lncli wallet estimatefee returns the fee estimation of the onchain backend to achieve a given confirmation target.

fixes #8726

coderabbitai · 2024-05-05T21:36:50Z

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)

llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

guggero · 2024-05-08T06:58:29Z

cmd/lncli/walletrpc_active.go

@@ -124,6 +126,45 @@ func getWalletClient(ctx *cli.Context) (walletrpc.WalletKitClient, func()) {
 	return walletrpc.NewWalletKitClient(conn), cleanUp
 }

+var estimateOnchainFeeCommand = cli.Command{
+	Name: "estimatefee",


Since this will return a fee rate (not an absolute fee), I think we should rename the command to estimatefeerate (which will also help to differentiate it from the existing top-level estimatefee command.

ellemouton

tACK! Looking good - a couple of nits & also think the estimatefeerate name would still work better

cmd/lncli/walletrpc_active.go

feelancer21 · 2024-05-08T10:20:54Z

@ellemouton @guggero: Thanks for the fast review. I have added all your comments to the code.

cmd/lncli/walletrpc_active.go

ellemouton · 2024-05-08T10:52:08Z

@feelancer21 - I dont think all the comments were addressed (referring to the s/feerate/fee rate comments)

feelancer21 · 2024-05-08T11:12:30Z

Sorry, my brain read "s/fee/feerate/" and skipped it. Is added now.

ellemouton

looking good - last comment is about instead moving this out of the wallet commands and to instead add it to the On-chain command sent since this isnt wallet related

EDIT: let me check with @guggero first to see if he agrees though

EDIT: never mind - i see it depends on wallet rpc

ellemouton

lgtm!

feelancer21 · 2024-05-08T14:46:04Z

Great. Yes, the dependency to walletrpc was the reason to make it a subcommand for lncli wallet.

lightninglabs-deploy · 2024-06-05T17:59:45Z

@feelancer21, remember to re-request review from reviewers when ready

feelancer21 · 2024-06-06T22:42:59Z

rebased for 0.18.1

guggero

Thanks for rebasing. Almost there, one nit and one suggestion.

guggero · 2024-06-07T07:22:02Z

cmd/lncli/walletrpc_active.go

+	}
+
+	resp, err := client.EstimateFee(ctxc, &walletrpc.EstimateFeeRequest{
+		ConfTarget: int32(confTarget)})


nit: closing bracket and parenthesis need to be on new line.

Wondering if there is a setting in vscode that the go fromatter can do it for me?

Unfortunately, the tooling support here isn't great. I wish something like prettier existed for Golang.

guggero · 2024-06-07T07:26:04Z

cmd/lncli/walletrpc_active.go

+		return err
+	}
+
+	printJSON(resp)


We could also offer this as sat_per_vbyte for the user's convenience.
So something like this (untested):

rateKW := chainfee.SatPerKWeight(resp.SatPerKw) rateVB := rateKW.FeePerVByte() printJSON(struct { SatPerKw int64 `json:"sat_per_kw"` SatPerVByte int64 `json:"sat_per_vbyte"` }{ SatPerKw: int64(rateKW), SatPerVByte: int64(rateVB), })

Thanks for the suggestion. I had the same idea at some point, but didn't follow it up. I took the snippet and tested it once.

ellemouton · 2024-06-11T17:41:26Z

@feelancer21 - could you rebase onto latest master pls?

`lncli wallet estimatefeerate` returns the fee rate estimate for on-chain transactions in sat/kw and sat/vb to achieve a given confirmation target.

feelancer21 · 2024-06-11T19:58:52Z

@ellemouton done

feelancer21 marked this pull request as draft May 6, 2024 00:52

feelancer21 mentioned this pull request May 6, 2024

[feature]: lncli command for walletrpc.EstimateFee #8726

Closed

feelancer21 force-pushed the lncli-wallet-estimatefee branch from 34cfecb to dbe3c2a Compare May 7, 2024 22:23

feelancer21 marked this pull request as ready for review May 7, 2024 22:30

guggero reviewed May 8, 2024

View reviewed changes

ellemouton reviewed May 8, 2024

View reviewed changes

feelancer21 force-pushed the lncli-wallet-estimatefee branch from dbe3c2a to 95dd44d Compare May 8, 2024 10:19

ellemouton reviewed May 8, 2024

View reviewed changes

cmd/lncli/walletrpc_active.go Outdated Show resolved Hide resolved

guggero changed the title ~~lncli: new command wallet estimatefee~~ lncli: new command wallet estimatefeerate May 8, 2024

feelancer21 force-pushed the lncli-wallet-estimatefee branch from 95dd44d to c3792dc Compare May 8, 2024 11:09

ellemouton reviewed May 8, 2024

View reviewed changes

ellemouton approved these changes May 8, 2024

View reviewed changes

saubyk assigned feelancer21 May 8, 2024

saubyk added wallet The wallet (lnwallet) which LND uses fees Related to the fees paid for transactions (both LN and funding/commitment transactions) rpc Related to the RPC interface labels May 8, 2024

feelancer21 force-pushed the lncli-wallet-estimatefee branch from c3792dc to 5ffb5a0 Compare June 6, 2024 22:41

guggero added this to the v0.18.1 milestone Jun 7, 2024

guggero reviewed Jun 7, 2024

View reviewed changes

feelancer21 force-pushed the lncli-wallet-estimatefee branch from 5ffb5a0 to 4d6e01a Compare June 10, 2024 13:48

guggero approved these changes Jun 10, 2024

View reviewed changes

lncli: new command wallet estimatefeerate

fc90bc9

`lncli wallet estimatefeerate` returns the fee rate estimate for on-chain transactions in sat/kw and sat/vb to achieve a given confirmation target.

feelancer21 force-pushed the lncli-wallet-estimatefee branch from 4d6e01a to fc90bc9 Compare June 11, 2024 19:57

ellemouton merged commit 26892a2 into lightningnetwork:master Jun 12, 2024
27 of 34 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lncli: new command `wallet estimatefeerate` #8730

lncli: new command `wallet estimatefeerate` #8730

feelancer21 commented May 5, 2024 •

edited

Loading

coderabbitai bot commented May 5, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

guggero May 8, 2024

ellemouton left a comment

feelancer21 commented May 8, 2024

ellemouton commented May 8, 2024 •

edited

Loading

feelancer21 commented May 8, 2024

ellemouton left a comment •

edited

Loading

ellemouton left a comment

feelancer21 commented May 8, 2024 •

edited

Loading

lightninglabs-deploy commented Jun 5, 2024

feelancer21 commented Jun 6, 2024

guggero left a comment

guggero Jun 7, 2024

feelancer21 Jun 10, 2024

guggero Jun 10, 2024

guggero Jun 7, 2024

feelancer21 Jun 10, 2024

ellemouton commented Jun 11, 2024

feelancer21 commented Jun 11, 2024

lncli: new command wallet estimatefeerate #8730

lncli: new command wallet estimatefeerate #8730

Conversation

feelancer21 commented May 5, 2024 • edited Loading

coderabbitai bot commented May 5, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

guggero May 8, 2024

Choose a reason for hiding this comment

ellemouton left a comment

Choose a reason for hiding this comment

feelancer21 commented May 8, 2024

ellemouton commented May 8, 2024 • edited Loading

feelancer21 commented May 8, 2024

ellemouton left a comment • edited Loading

Choose a reason for hiding this comment

ellemouton left a comment

Choose a reason for hiding this comment

feelancer21 commented May 8, 2024 • edited Loading

lightninglabs-deploy commented Jun 5, 2024

feelancer21 commented Jun 6, 2024

guggero left a comment

Choose a reason for hiding this comment

guggero Jun 7, 2024

Choose a reason for hiding this comment

feelancer21 Jun 10, 2024

Choose a reason for hiding this comment

guggero Jun 10, 2024

Choose a reason for hiding this comment

guggero Jun 7, 2024

Choose a reason for hiding this comment

feelancer21 Jun 10, 2024

Choose a reason for hiding this comment

ellemouton commented Jun 11, 2024

feelancer21 commented Jun 11, 2024

lncli: new command `wallet estimatefeerate` #8730

lncli: new command `wallet estimatefeerate` #8730

feelancer21 commented May 5, 2024 •

edited

Loading

coderabbitai bot commented May 5, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

ellemouton commented May 8, 2024 •

edited

Loading

ellemouton left a comment •

edited

Loading

feelancer21 commented May 8, 2024 •

edited

Loading