Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bumpforceclose behavior for force closes without htlcs. #8946

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Fix bumpforceclose behavior for force closes without htlcs. #8946

merged 3 commits into from
Jul 30, 2024

Conversation

ziggie1984
Copy link
Collaborator

@ziggie1984 ziggie1984 commented Jul 29, 2024 •
edited
Loading

Resulted from #8843

Splitted the PR to first address the bugfix.

Fixes #8837

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 29, 2024

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)
  • llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ziggie1984 ziggie1984 force-pushed the fix-bumpforceclose-behaviour branch from 754b9f8 to 8e3f3b0 Compare July 29, 2024 09:24
@ziggie1984 ziggie1984 marked this pull request as ready for review July 29, 2024 09:25
@ziggie1984 ziggie1984 added this to the v0.18.3 milestone Jul 29, 2024
@ziggie1984 ziggie1984 self-assigned this Jul 29, 2024
@ziggie1984 ziggie1984 mentioned this pull request Jul 29, 2024
Merged
@ziggie1984 ziggie1984 force-pushed the fix-bumpforceclose-behaviour branch from 8e3f3b0 to 540ec63 Compare July 29, 2024 14:57
ProofOfKeags
ProofOfKeags reviewed Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@ProofOfKeags ProofOfKeags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one squint I'd like to discuss.

@ziggie1984 ziggie1984 force-pushed the fix-bumpforceclose-behaviour branch from 540ec63 to f848b28 Compare July 30, 2024 10:03
yyforyongyu
yyforyongyu reviewed Jul 30, 2024
View reviewed changes
Copy link
Member

@yyforyongyu yyforyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach ACK, we now need to fix the itest🤖

@ziggie1984 ziggie1984 force-pushed the fix-bumpforceclose-behaviour branch 2 times, most recently from 50f5d5b to e18af97 Compare July 30, 2024 13:34
@ziggie1984
Copy link
Collaborator Author

Itests pass, I guess we can ship this one

yyforyongyu
yyforyongyu approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@yyforyongyu yyforyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🎉

ProofOfKeags
ProofOfKeags approved these changes Jul 30, 2024
View reviewed changes
@ziggie1984 ziggie1984 force-pushed the fix-bumpforceclose-behaviour branch from e18af97 to e973f92 Compare July 30, 2024 18:30
@ziggie1984
contractcourt: Always register anchors with sweeper.
e413759 
Even if no HTLCs are at stake we are going to register the anchor
outputs with the sweeper subsystem with a default high deadline.
We need to do this, because otherwise we are not able to bump the
fee of the closing transaction manually.
@ziggie1984
itest: adapt itest for the new anchor behavior.
cac5b32 
Now we also register anchors when no HTLCs are at stake.
@ziggie1984
docs: add release-notes.
da7b95d
@ziggie1984 ziggie1984 force-pushed the fix-bumpforceclose-behaviour branch from e973f92 to da7b95d Compare July 30, 2024 18:31
@ProofOfKeags ProofOfKeags enabled auto-merge July 30, 2024 19:16
@ProofOfKeags ProofOfKeags merged commit 67c5fa9 into lightningnetwork:master Jul 30, 2024
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProofOfKeags ProofOfKeags ProofOfKeags approved these changes

@yyforyongyu yyforyongyu yyforyongyu approved these changes

Assignees

@ziggie1984 ziggie1984

Labels
force closes
Projects
None yet
Milestone
v0.18.3
Development

Successfully merging this pull request may close these issues.

[bug]: Not able to bumpclosefee of an anchor channel in a special case (no HLTCs at stake).
3 participants
@ziggie1984 @ProofOfKeags @yyforyongyu