Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MICRO]: channeldb+lnwallet: add OpeningParty API #8968

Merged
merged 1 commit into from
Aug 5, 2024
Merged

[MICRO]: channeldb+lnwallet: add OpeningParty API #8968

merged 1 commit into from
Aug 5, 2024

Conversation

ProofOfKeags
Copy link
Collaborator

Change Description

Spinoff from #8755. Useful for #8270 refactor. Simple API addition to convert database boolean representation to the ChannelParty domain type.

Steps to Test

n/a

Pull Request Checklist

Testing

  • Your PR passes all CI checks.
  • Tests covering the positive and negative (error paths) are included.
  • Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

📝 Please see our Contribution Guidelines for further guidance.

@ProofOfKeags ProofOfKeags added this to the v0.19.0 milestone Aug 1, 2024
@ProofOfKeags ProofOfKeags self-assigned this Aug 1, 2024
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 1, 2024

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)
  • llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ProofOfKeags ProofOfKeags added size/nano trivial move, refactor, renames size/micro small bug fix or feature, less than 15 mins of review, less than 250 and removed size/nano trivial move, refactor, renames labels Aug 1, 2024
@ProofOfKeags ProofOfKeags changed the title [NANO]: channeldb+lnwallet: add OpeningParty API [MICRO]: channeldb+lnwallet: add OpeningParty API Aug 1, 2024
Roasbeef
Roasbeef requested changes Aug 2, 2024
View reviewed changes
channeldb/channel.go Outdated
if c.IsInitiator {
return lntypes.Local
} else {
return lntypes.Remote
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do an early return as the linter notes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not really an early return though. Both levels are "equally privileged". I'll change though to please the lint gods.

@ProofOfKeags ProofOfKeags requested a review from Roasbeef August 2, 2024 00:39
carlaKC
carlaKC approved these changes Aug 2, 2024
View reviewed changes
@ProofOfKeags
channeldb+lnwallet: define Initiator for OpenChannel and LightningCha…
a2b19af 
…nnel

This commit introduces a new API to return information on which party opened
the channel using the new ChannelParty type. It does not change the underlying
structure of how we store this information.
Roasbeef
Roasbeef approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📊

@Roasbeef Roasbeef merged commit c262b1b into lightningnetwork:master Aug 5, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlaKC carlaKC carlaKC approved these changes

@Roasbeef Roasbeef Roasbeef approved these changes

Assignees

@ProofOfKeags ProofOfKeags

Labels
no-changelog no-itest size/micro small bug fix or feature, less than 15 mins of review, less than 250
Projects
lnd v0.19
Status: Done
Milestone
v0.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ProofOfKeags @Roasbeef @carlaKC