-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lnrpc: update falafel version #8974
Conversation
Important Review skippedAuto reviews are limited to specific labels. Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
e3f08a7
to
10b5e80
Compare
135107c
to
820cb6b
Compare
(the race caught here is fixed in #8976) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending a bump to the final version once we pushed a new tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Niiice! Wanted this feature for quite some time, thanks for figuring this out!
132ec46
to
e33edb5
Compare
Update the falafel version.
With the updated falafel version, there is no longer a need to specify manual imports.
e33edb5
to
2d00859
Compare
Update the version of falafel used during proto generation. The updated falafel version supports proto3 optional fields (meaning we can then start to use those in our proto files) and it also removes the need to specify "manual_imports" for our generated stubs.
Depends on: lightninglabs/falafel#12 being merged + new tag there.