Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lnwallet: correctly set UpdateAddHTLC.BlindingPoint on reload from disk #9023

Merged
merged 3 commits into from
Aug 22, 2024
Merged

lnwallet: correctly set UpdateAddHTLC.BlindingPoint on reload from disk #9023

merged 3 commits into from
Aug 22, 2024

Conversation

ellemouton
Copy link
Collaborator

Correctly set the UpdateAddHTLC.BlindingPoint member when reading LogUpdates from disk. This PR also adds a test to cover this case.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 22, 2024

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)
  • llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ellemouton ellemouton force-pushed the testHTLCPersistenceAcrossRestart branch from 0a486a1 to cb1d082 Compare August 22, 2024 09:28
guggero
guggero approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you so much for the reproduction itest!
Should this go into 0.18.3 even? Since that's still in RC and this does constitute a bug fix.

@ellemouton ellemouton force-pushed the testHTLCPersistenceAcrossRestart branch from cb1d082 to 641140d Compare August 22, 2024 10:14
@ellemouton ellemouton changed the base branch from master to 0-18-3-branch August 22, 2024 10:15
@ellemouton ellemouton force-pushed the testHTLCPersistenceAcrossRestart branch from 641140d to 43a062c Compare August 22, 2024 10:18
@ellemouton
Copy link
Collaborator Author

Should this go into 0.18.3 even? Since that's still in RC and this does constitute a bug fix.

good idea - changed the base to 0.18.3 & moved release notes 👍

@ellemouton
Copy link
Collaborator Author

erg sorry rebase things. fixing

@ellemouton ellemouton force-pushed the testHTLCPersistenceAcrossRestart branch from 43a062c to 843a4a9 Compare August 22, 2024 10:31
@guggero guggero added this to the v0.18.3 milestone Aug 22, 2024
ziggie1984
ziggie1984 approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@ziggie1984 ziggie1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch 👏

@ellemouton
itest: demonstrate UpdateAddHTLC reloading bug
58fa379 
This commit adds a new route blinding itest that demonstrates that the
reloading and re-forwarding of an UpdateAddHTLC message on restart
currently is done incorrectly for a blinded path payment. This is due to
the fact that the blinding point member is not currently set correctly.
This is fixed in the next commit which will also change the test to
assert that the behaviour is now correct.
@ellemouton
lnwallet+itest: fix PaymentDescriptor creation for blinded path htlc
fcbd1e1 
This commit fixes the instantiation of the BlindingPoint member of
PaymentDescriptor during the conversion from persisted LogUpdates.
Previously, the blinding point was not set correctly. The test from the
previous commit is also updated to now assert that this behaviour is now
correct.
@ellemouton
docs: update release notes
e99b09d
@ellemouton ellemouton force-pushed the testHTLCPersistenceAcrossRestart branch from 843a4a9 to e99b09d Compare August 22, 2024 12:21
@guggero guggero merged commit 8f25de0 into lightningnetwork:0-18-3-branch Aug 22, 2024
26 of 27 checks passed
@ellemouton ellemouton deleted the testHTLCPersistenceAcrossRestart branch August 22, 2024 14:07
@guggero
Copy link
Collaborator

guggero commented Aug 27, 2024

@ellemouton I think we also need this PR on the master branch! Or will this be included in another PR?

@ellemouton
Copy link
Collaborator Author

ah - cool i can re-open on master

@ellemouton ellemouton mentioned this pull request Aug 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guggero guggero guggero approved these changes

@ziggie1984 ziggie1984 ziggie1984 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.18.3
Development

Successfully merging this pull request may close these issues.
3 participants
@ellemouton @guggero @ziggie1984