HTLC number mismatch fixes #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an out of bounds error that would occur in the case where we received a new commitment where the accompanying HTLC sigs were too few. Now we'll just reject such an commitment. A test exercising the behavior is also added.
This commit fixes an issue where we would blindly accept a commitment which came without any accompanying HTLC signatures. A test exercising the scenario is added.
This commit fixes an issue which would arise in some cases when the local and remote dust limits would differ, resulting in lnd not producing the expected number of HTLC signatures. This was a result of checking dust against the local instead of the remote dust limit. A test exercising the scenario is added.
This commit adds a check that will make LightningChannel reject a
received commitment if it is accompanied with too many HTLC signatures.
This enforces the requirement in BOLT-2, saying:
if num_htlcs is not equal to the number of HTLC outputs in the local commitment transaction:
* MUST fail the channel.
A test exercising the behaviour is added.
halseth
force-pushed
the
dustlimit-remote-fix
branch
from
17d79be to
a6e7dce
Compare
Closed
Roasbeef
approved these changes
Mar 23, 2018
There was a problem hiding this comment.
LGTM 👾
Strange that this took so long for us to detect, but shows the advantages of having hetegrnemus implementations on the network.
Excellent job with the commit structure! It made the set of changes easy to follow due to the constructive nature of the fix, and accompanying failing test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix a number of issues that would arise because we allowed creating and receiving HTLC signatures that didn't match the number of HTLC outputs on the commitment.
Fixes #547