graph: extract cache from CRUD [5] #9552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
ellemouton
force-pushed
the
graph16
branch
2 times, most recently
from
0c012d3 to
8d6bea8
Compare
Here, we move the business logic in FilterKnownChanIDs from the CRUD layer to the ChannelGraph layer. We also add a test for the logic.
From the KVStore to the ChannelGraph.
To the ChannelGraph.
yyforyongyu
approved these changes
Feb 27, 2025
| // | ||
| // NOTE: this tests focuses on zombie revival. The main logic of | ||
| // FilterKnownChanIDs is tested in TestFilterKnownChanIDs. | ||
| func TestFilterKnownChanIDsZombieRevival(t *testing.T) { |
ellemouton
merged commit 5eb96dc
into
lightningnetwork:elle-graphCacheBase
30 of 34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** PR 5 ** (note: not dependent on PR 3 or 4)
This builds towards this final result by building this side branch incrementally.
In this PR, we move the cache writes for
MarkEdgeZombieandUpdateEdgePolicyfrom the KVStore to the ChannelGraph. For the MarkEdgeZombie change, we first need to adjustFilterKnownChanIDsso that its zombie related business logic is moved out of the CRUD code and into the ChannelGraph layer - so this is done as a first commit here. Note that this part replaces this PR which made this move to the ChanSeries layer - but it makes more sense to keep this out of that layer.