Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create step-by-step send payment workflow for newcomers with docker #99

Merged
merged 3 commits into from
Jan 13, 2017

Conversation

andrewshvv
Copy link
Contributor

No description provided.

developers of `lnd`. The set of specification documents as well as our
implementation of the specification are still a work-in-progress. With that
said, `lnd` the current status of `lnd`'s BOLT compliance is:
Current implementation doesn't yet _fully_ conform to the [Lightning Network specification (BOLT's)](https://github.com/lightningnetwork/lightning-rfc). `BOLT` stands for: Basic of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can revert it back to how it was originally. lnd is fine there.

## IRC
* irc.freenode.net
* channel #lnd
* [webchat](https://webchat.freenode.net/?channels=lnd)

## License
`lnd` is licensed under the [MIT license](https://github.com/lightningnetwork/lnd/blob/master/LICENSE).
## Farther reading
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be:

Further reading

@@ -1 +1,112 @@
### Getting started
This document is written for people who eager try to do something with
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for people who are eager to

### Getting started
This document is written for people who eager try to do something with
lightning network daemon (`lnd`). Current workflow is big because we
recreate the whole ecosystem by ourselves, next versions will use the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recreate the whole network by ourselves

+ - - - - - + - - - - - - +
|
+ ---------------- +
| Bitcoin network | <--- In current scenarion for simplicity we create only one
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scenario

$ docker-compose run btcctl generate 201
```

Now we have `btcd` node turned on and some amount of bitcoins mined on
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why's this section needed? It should work without a restart.

Send the payment form "Alice" to "Bob".
```
# Add invoice on "Bob" side:
bob> lncli addinvoice --value=10000 --preimage="0000000000000000000000000000000000000000000000000000000000000000"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can leave off the preimage parameters, and the daemon is create one with a random payment hash.

bob> lncli addinvoice --value=10000 --preimage="0000000000000000000000000000000000000000000000000000000000000000"

# Send payment from "Alice" to "Bob":
alice> lncli sendpayment --dest="<bob_pub_key>" --amt=10000 --payment_hash="<>" --debug_send="false"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command can use the encoded "payment_request" that's returned by the addinvoice command. So you can do lncil sendpayment --pay_req=<encoded invoice.

upcoming upgrade to Bitcoin: Segregated Witness (`segwit`). The
project's codebase uses the [btcsuite](https://github.com/btcsuite/) set
of Bitcoin libraries, and is currently dependant on [btcd](https://github.com/btcsuite/btcd).
In current state `lnd` is capable of:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the current state

In order to build form source, the following build dependencies are
required:

* **Go:** Installation instructions can be found [here](http://golang.org/doc/install).
It is recommended to add `$GOPATH/bin` to your `PATH` at this point.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a new line should be inserted after this line.

@andrewshvv andrewshvv force-pushed the docker-improvements branch 5 times, most recently from 9f77d4d to f44e59a Compare January 12, 2017 00:58
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! This should make it much easier for folks to get both btcd and lnd up and running in a nice package. As we discussed offline, there should also be a BITCOIN_NETWORK ENV variable that let's users toggle between testnet and simnet.

LGTM 🌟

@Roasbeef Roasbeef merged commit 299217a into lightningnetwork:master Jan 13, 2017
mrfelton pushed a commit to LN-Zap/lnd that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants