Use SymfonyFixturesLoader to load fixtures #432

magnetik · 2018-06-14T13:58:59Z

It's another try to fix #411.

The downside of the SymfonyFixturesLoader is that it always load all fixtures and cannot load a subset of it.

So I wrapped around some code to load only needed dependencies.

The test are not passing, but I'm not sure why as I can use it in my project.

alexislefebvre · 2018-06-22T12:49:22Z

@magnetik I fixed tests in #433, you can rebase your PR on the 2.x branch and tests should work again.

…quire injected service

rvanlaak · 2018-07-11T14:49:15Z

As "symfony/framework-bundle": "^3.4 || ^4.0" is the requirement on 2.x, having auto-wiring on fixtures as the new default would be great for the new release 👍

magnetik · 2018-07-11T14:56:33Z

I think some test are failing because of my limited knowledge of functional tests. I'll take a look tomorrow but if you feel like taking a look I can use some help !

I'm quite confident that the feature is working as I use it in a dev project I have.

rvanlaak · 2018-07-11T14:57:00Z

tests/App/config.yml

+    _defaults:
+        autowire: true
+        autoconfigure: true
+    Liip\FunctionalTestBundle\Tests\App\DataFixtures\ORM\:


I think tests are failing because the service on this resource import should be tagged as fixture.

Liip\FunctionalTestBundle\Tests\App\DataFixtures\ORM\: resource: 'DataFixtures/ORM/*' tags: ['doctrine.fixture.orm']

see http://symfony.com/doc/current/bundles/DoctrineFixturesBundle/index.html#loading-fixtures

created magnetik#1 for you

humm, I was thinking that the "autoconfigure" should have taken care of this automagically (as test are implementing the right interface)

I am not sure if DoctrineFixturesBundle did add __instanceof, but you might be right. Checking now if they did..

https://symfony.com/blog/new-in-symfony-3-3-service-autoconfiguration

You are right, implementing ORMFixtureInterface should be enough to autoconfigure the doctrine.fixture.orm tag, whereafter FixturesCompilerPass will add the fixture to the definition of doctrine.fixtures.loader.

https://github.com/doctrine/DoctrineFixturesBundle/blob/master/DependencyInjection/DoctrineFixturesExtension.php

https://github.com/doctrine/DoctrineFixturesBundle/blob/master/DependencyInjection/CompilerPass/FixturesCompilerPass.php

I've added the tag definition in the config.yml and the test are passing. Is that something that can be related to order in which the services are loaded ?

Then I guess the DoctrineFixturesBundle is not loaded / included with the test environment's AppKernel?

That would also explain why it's working in your dev environment, as you probably did include the bundle in your kernel over there.

magnetik · 2018-07-12T08:51:02Z

Okay so now it's green except for lowest dependencies.

And I've no idea why :D

magnetik · 2018-07-12T09:48:50Z

Okay so it requires doctrine-fixtures-bundle 3.0.2 (3.0.0 is bugged).

I've adapted the composer.json :)

rvanlaak · 2018-07-12T10:36:42Z

🎉

@alexislefebvre would be great if 2.0.0-alpha5 could get released after this PR is merged

rvanlaak · 2018-07-16T11:36:46Z

Or maybe @maximgubar could help us in getting this merged and releasing 2.0.0-alpha5?

alexislefebvre · 2018-07-16T12:03:55Z

tests/App/DataFixtures/ORM/LoadUserWithServiceData.php

+
+    public function __construct(TokenStorageInterface $tokenStorage)
+    {
+        $this->tokenStorage = $tokenStorage;


Is there a way to use $this->tokenStorage in this test? I would like to ensure that this service is callable.

I've added a call in the load method.

alexislefebvre · 2018-07-16T12:33:02Z

LGTM, I'm surprised that it doesn't break anything even though the fixture loader has been changed.

Thanks!

magnetik · 2018-07-16T13:31:15Z

I'm expecting quite a few bugs to pop in, regarding DX with the declaration of the service and so on.

Let's see how it goes when an alpha is released :)

rvanlaak · 2018-07-16T14:05:32Z

Where the previous fixture loader did simply rely on plain old class instantiation or a service definition, the loader now basically is enhanced by one that supports autowiring and autoconfiguration. In other words, as long as userland's service definitions are valid everything should be fine. Before vs After 🎉 Really looking forward to this!

alexislefebvre · 2018-07-16T14:10:24Z

Could you please add a small documentation about these changes in https://github.com/liip/LiipFunctionalTestBundle/blob/2.x/CHANGELOG.md, and https://github.com/liip/LiipFunctionalTestBundle/blob/2.x/UPGRADE-2.0.md if this is a breaking change?

magnetik · 2018-07-16T14:20:47Z

Done

alexislefebvre · 2018-07-16T20:39:10Z

Thanks @magnetik and @rvanlaak for your work on this PR, I released the 2.0.0-alpha5 version: https://github.com/liip/LiipFunctionalTestBundle/releases/tag/2.0.0-alpha5

Jibbarth · 2018-07-17T09:17:37Z

composer.json

@@ -25,9 +25,9 @@
        "symfony/phpunit-bridge": "^3.4 || ^4.0",
        "doctrine/orm": "^2.6",
        "symfony/monolog-bundle": "^3.1",
-        "doctrine/doctrine-fixtures-bundle": "^3.0",
+        "doctrine/doctrine-fixtures-bundle": "^3.0 >=3.0.2",


This line shouldn't be in require section instead of require-dev ?
Since we use it in Services\FixturesLoaderFactory, it's became a dependency, WDYT ?

Got this error when updating to 2.0.0-alpha5

The service "liip_functional_test.services.fixtures_loader_factory" has a dependency on a non-existent service "doctrine.fixtures.loader".

Hum so we should load the service only if the DoctrineFixturesBundle is available, because you should be able to use the bundle without using the fixtures

magnetik force-pushed the di-bug-fix branch from e6a1ff8 to ff237d6 Compare June 14, 2018 14:00

alexislefebvre added this to the 2.0 milestone Jun 14, 2018

Add a test case for not being able to load dependent fixtures that re…

77daf05

…quire injected service

magnetik force-pushed the di-bug-fix branch from ff237d6 to fecf0f1 Compare June 25, 2018 08:15

magnetik closed this Jul 11, 2018

magnetik reopened this Jul 11, 2018

rvanlaak suggested changes Jul 11, 2018

View reviewed changes

rvanlaak mentioned this pull request Jul 11, 2018

Tag fixtures for visibility to SymfonyFixtureLoader magnetik/LiipFunctionalTestBundle#1

Closed

magnetik force-pushed the di-bug-fix branch 3 times, most recently from 4763025 to 030d4d8 Compare July 12, 2018 08:35

magnetik force-pushed the di-bug-fix branch 5 times, most recently from 97dddd2 to cbd2ba6 Compare July 12, 2018 09:48

magnetik force-pushed the di-bug-fix branch from cbd2ba6 to 5441719 Compare July 12, 2018 09:50

alexislefebvre approved these changes Jul 16, 2018

View reviewed changes

alexislefebvre reviewed Jul 16, 2018

View reviewed changes

magnetik force-pushed the di-bug-fix branch from 5441719 to 712d551 Compare July 16, 2018 12:16

Use SymfonyFixturesLoader

86ab306

magnetik force-pushed the di-bug-fix branch from 712d551 to 86ab306 Compare July 16, 2018 14:19

alexislefebvre merged commit 15e82b4 into liip:2.x Jul 16, 2018

Jibbarth reviewed Jul 17, 2018

View reviewed changes

magnetik mentioned this pull request Jul 17, 2018

Make doctrine-fixtures-bundle non mandatory #437

Merged

alexislefebvre mentioned this pull request Jul 17, 2018

Discussion about 2.0 release #381

Closed

12 tasks

alcaeus mentioned this pull request Feb 1, 2019

ArgumentCountError - Fixtures with DI and with DependentFixtureInterface doctrine/data-fixtures#295

Closed

alexislefebvre mentioned this pull request Jul 20, 2021

Is doctrine/doctrine-fixtures-bundle required when using theofidry/alice-data-fixtures? liip/LiipTestFixturesBundle#86

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use SymfonyFixturesLoader to load fixtures #432

Use SymfonyFixturesLoader to load fixtures #432

magnetik commented Jun 14, 2018

alexislefebvre commented Jun 22, 2018

rvanlaak commented Jul 11, 2018

magnetik commented Jul 11, 2018

rvanlaak Jul 11, 2018

rvanlaak Jul 11, 2018

magnetik Jul 11, 2018

rvanlaak Jul 11, 2018

rvanlaak Jul 11, 2018

magnetik Jul 12, 2018

rvanlaak Jul 12, 2018

magnetik commented Jul 12, 2018 •

edited

Loading

magnetik commented Jul 12, 2018

rvanlaak commented Jul 12, 2018

rvanlaak commented Jul 16, 2018

alexislefebvre Jul 16, 2018

magnetik Jul 16, 2018

alexislefebvre commented Jul 16, 2018

magnetik commented Jul 16, 2018 •

edited

Loading

rvanlaak commented Jul 16, 2018

alexislefebvre commented Jul 16, 2018

magnetik commented Jul 16, 2018

alexislefebvre commented Jul 16, 2018

Jibbarth Jul 17, 2018

magnetik Jul 17, 2018

magnetik Jul 17, 2018

Use SymfonyFixturesLoader to load fixtures #432

Use SymfonyFixturesLoader to load fixtures #432

Conversation

magnetik commented Jun 14, 2018

alexislefebvre commented Jun 22, 2018

rvanlaak commented Jul 11, 2018

magnetik commented Jul 11, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

magnetik commented Jul 12, 2018 • edited Loading

magnetik commented Jul 12, 2018

rvanlaak commented Jul 12, 2018

rvanlaak commented Jul 16, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexislefebvre commented Jul 16, 2018

magnetik commented Jul 16, 2018 • edited Loading

rvanlaak commented Jul 16, 2018

alexislefebvre commented Jul 16, 2018

magnetik commented Jul 16, 2018

alexislefebvre commented Jul 16, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

magnetik commented Jul 12, 2018 •

edited

Loading

magnetik commented Jul 16, 2018 •

edited

Loading