Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routing file configuration #1509

Merged
merged 1 commit into from
Apr 30, 2023
Merged

Routing file configuration #1509

merged 1 commit into from
Apr 30, 2023

Conversation

StevenRenaux
Copy link
Contributor

Q A
Branch? 2.x
Doc Routing file configuration

Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, i see this is how the flex recipe sets the bundle up. i agree it makes sense to follow that naming.

it would make sense to have the symfony flex instructions at the top and only specify the manual steps as alternative. do you want to contribute that to the documentation as well?

@dbu dbu merged commit cb23948 into liip:2.x Apr 30, 2023
StevenRenaux added a commit to StevenRenaux/LiipImagineBundle that referenced this pull request May 1, 2023
Relative at liip#1509 (comment)

Add about Symfony Flex recipe
@StevenRenaux
Copy link
Contributor Author

ah, i see this is how the flex recipe sets the bundle up. i agree it makes sense to follow that naming.

it would make sense to have the symfony flex instructions at the top and only specify the manual steps as alternative. do you want to contribute that to the documentation as well?

Yeah it's the #1510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants