Fix #769 #770
Fix #769 #770
Conversation
| $ratio = max($widthRatio, $heightRatio); | ||
| } else { | ||
| $ratio = min($widthRatio, $heightRatio); | ||
| } |
There was a problem hiding this comment.
could this be $ratio = ($width === null || $height === null) ? max($widthRatio, $heightRatio) : min($widthRatio, $heightRatio); ?
There was a problem hiding this comment.
Of course, either way that is just a style thing, I don't think it will be a performance issue, so I'm okay with anything. you might see this info http://stackoverflow.com/a/11643364
There was a problem hiding this comment.
in Symfony we generally use null === $foo
If image smaller in dimensions than the max arguments, Downscale doesn't upscale, and if image greater in dimensions than min arguments Upscale doesn't downscale.
|
|
||
| if ($ratio > 1) { | ||
| return $image; | ||
| } |
There was a problem hiding this comment.
Could be controversial thing, discuss on this 🎱
There was a problem hiding this comment.
hah, now that's my kinda fix! 😉
There was a problem hiding this comment.
this should be an option, defaulting to off
There was a problem hiding this comment.
I was thinking more like, creating another filter "scale" which will do either, the filters should do only what they should, I don't know maybe it's just clear that way, moreover downscale and upscale should be derived from scale
|
Then I'll close this and work on the filter, with another feature for these filters |
This permanently and efficiently fixes the problem