Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix travis build definition for conditional dependencies #797

Closed
wants to merge 1 commit into from

Conversation

cedricziel
Copy link
Collaborator

This change adjusts the before_install section to correctly install the optional dependencies.

Before this commit, the if statements silently failed (you can see that in the older build-logs), and the corresponding tests were skipped.

The patch ensures that the dependencies for ext-mongo, the odm and flysystem are installed so that the tests aren't skipped anymore.

@robfrawley
Copy link
Collaborator

Thanks for the PRs! Looks like the issue you are targeting was already addressed in #792.

@cedricziel
Copy link
Collaborator Author

Ahh, snap! :)

Thank you for the hint.

@cedricziel cedricziel closed this Sep 16, 2016
@cedricziel cedricziel deleted the travisFixScripts branch September 16, 2016 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants