Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BoxConstraints::UNBOUNDED #1126

Merged
merged 3 commits into from
Aug 18, 2020
Merged

Conversation

danieldulaney
Copy link
Contributor

  • BoxConstraints::UNBOUNDED is a constant that leaves the dimensions unconstrained
  • Added tests confirming BoxConstraints::UNBOUNDED properties

* BoxConstraints::UNBOUNDED is a constant that leaves the dimensions
  unconstrained

* Added tests confirming BoxConstraints::UNBOUNDED properties
@danieldulaney danieldulaney marked this pull request as ready for review August 12, 2020 05:01
Copy link
Collaborator

@richard-uk1 richard-uk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice thing to have. I'll see what others say as well.

Copy link
Collaborator

@luleyleo luleyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, the changelog needs a fix though.

CHANGELOG.md Outdated
@@ -14,6 +14,7 @@ You can find its changes [documented below](#060---2020-06-01).
- Re-export `druid_shell::Scalable` under `druid` namespace. ([#1075] by [@ForLoveOfCats])
- `TextBox` now supports ctrl and shift hotkeys. ([#1076] by [@vkahl])
- Added selection text color to textbox. ([#1093] by [@sysint64])
- Added `BoxConstraints::UNBOUNDED` constant. ([#1126] by [@danieldulaney])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The links must be added manually, see CONTRIBUTING.md.
Also, the "Added" prefix in the previous entry should not be there, nor should this entry have one.

@luleyleo luleyleo added the S-waiting-on-author waits for changes from the submitter label Aug 17, 2020
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I'll fixup the changelog and merge. :)

@luleyleo luleyleo merged commit 0c63b59 into linebender:master Aug 18, 2020
@luleyleo luleyleo removed the S-waiting-on-author waits for changes from the submitter label Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants