-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added BoxConstraints::UNBOUNDED #1126
Conversation
danieldulaney
commented
Aug 12, 2020
- BoxConstraints::UNBOUNDED is a constant that leaves the dimensions unconstrained
- Added tests confirming BoxConstraints::UNBOUNDED properties
* BoxConstraints::UNBOUNDED is a constant that leaves the dimensions unconstrained * Added tests confirming BoxConstraints::UNBOUNDED properties
9414501
to
73c3f46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a nice thing to have. I'll see what others say as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable, the changelog needs a fix though.
CHANGELOG.md
Outdated
@@ -14,6 +14,7 @@ You can find its changes [documented below](#060---2020-06-01). | |||
- Re-export `druid_shell::Scalable` under `druid` namespace. ([#1075] by [@ForLoveOfCats]) | |||
- `TextBox` now supports ctrl and shift hotkeys. ([#1076] by [@vkahl]) | |||
- Added selection text color to textbox. ([#1093] by [@sysint64]) | |||
- Added `BoxConstraints::UNBOUNDED` constant. ([#1126] by [@danieldulaney]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The links must be added manually, see CONTRIBUTING.md
.
Also, the "Added" prefix in the previous entry should not be there, nor should this entry have one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I'll fixup the changelog and merge. :)