Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reinstate the Scroll::scroll function. #1196

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Reinstate the Scroll::scroll function. #1196

merged 1 commit into from
Sep 9, 2020

Conversation

jneem
Copy link
Collaborator

@jneem jneem commented Sep 8, 2020

It seems like the Scroll::scroll function was removed in #1107, which I'm hoping was unintentional because I was using it. This PR reinstates it.

@jneem jneem requested a review from ForLoveOfCats September 8, 2020 23:22
ForLoveOfCats
ForLoveOfCats approved these changes Sep 9, 2020
View reviewed changes
Copy link
Collaborator

@ForLoveOfCats ForLoveOfCats left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was indeed unintentional! It was moved into ScrollComponent and simply wasn't re-implemented. Sorry about that! 😅

@jneem jneem merged commit b8667c9 into linebender:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForLoveOfCats ForLoveOfCats ForLoveOfCats approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jneem @ForLoveOfCats