cleanup game of life #1443
cleanup game of life #1443
Conversation
|
I need to get the vscode rust extension to work again. It just doesnt do anything useful. |
| @@ -57,7 +57,6 @@ impl Grid { | |||
| // death by loneliness or overcrowding | |||
| if life && (n_lives_around < 2 || n_lives_around > 3) { | |||
| indices_to_mutate.push(pos); | |||
| continue; | |||
There was a problem hiding this comment.
Whilst it is true that the code will perform identically without this continue, keeping it in might communicate intent better. What do you think?
There was a problem hiding this comment.
oh I actually thought it did the opposite, having a break/continue within a loop makes it harder to reason about.
After looking at the idiomatic implementation (https://rustwasm.github.io/book/game-of-life/implementing.html) I think using a match might actually be easiest to reason about?
| }; | ||
| use std::sync::Arc; | ||
|
|
||
| const GRID_SIZE: usize = 40; | ||
| const GRID_SIZE: usize = 41; |
There was a problem hiding this comment.
This is so that the background grid is not aligned. If it is aligned you get straight lines as cels which is a bit boring, and also doesn't highlight that it is actually a grid. This makes it so that neighboring cells (almost?? I dont know for sure anymore) always have a different colour.
druid/examples/game_of_life.rs
Outdated
| const C0: Color = Color::from_rgba32_u32(0xEBF1F7); //Color::rgb(235, 241, 247) | ||
| const C1: Color = Color::from_rgba32_u32(0xA3FCF7); //Color::rgb(162,252,247) | ||
| const C2: Color = Color::from_rgba32_u32(0xA2E3D8); //Color::rgb(162,227,216) | ||
| const C3: Color = Color::from_rgba32_u32(0xF2E6F1); //Color::rgb(242,230,241) | ||
| const C4: Color = Color::from_rgba32_u32(0xE0AFAF); //Color::rgb(224,175,175) |
There was a problem hiding this comment.
I agree that using Color::rgb would be better here.
There was a problem hiding this comment.
yup, but sadly that isnt possible. I made them already but they're not const so decided to put them as comments.
There was a problem hiding this comment.
Oh right I meant Color::rgb8. That's the const one that takes u8s:
const C0: Color = Color::rgb8(0xEB, 0xF1, 0xF7);
// same as:
const C0: Color = Color::from_rgba32_u32(0xEBF1F7);There was a problem hiding this comment.
I would also actually fix up these names while we're in here, like BG could be BACKGROUND and then I'd try and give more meaningful names to the other colors too?
There was a problem hiding this comment.
I just made it an array, much simpler.
|
I thought I left replied for this ages ago!!! now they're all gone... |
JAicewizard
force-pushed
the
rework_gol
branch
from
5624dfa to
7a1296f
Compare
This cleans some things up like using ? where applicable and removing unnecessary code.