Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow additional l10n resource in AppLauncher #1528

Merged
merged 3 commits into from
Jan 12, 2021
Merged

Allow additional l10n resource in AppLauncher #1528

merged 3 commits into from
Jan 12, 2021

Conversation

edwin0cheng
Copy link
Collaborator

This PR added localization_resource in AppLauncher, which enabled additional resource to use in app.

@edwin0cheng
Copy link
Collaborator Author

cc @cmyr

cmyr
cmyr reviewed Jan 11, 2021
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right general idea but I think I'd be less fancy; more details below.

@edwin0cheng edwin0cheng changed the title Add additional l10n resource in AppLauncher Allow additional l10n resource in AppLauncher Jan 11, 2021
@edwin0cheng
Copy link
Collaborator Author

And I refactor out the DEBUG_COLORS in Env::default, I could roll it back if you want.

cmyr
cmyr reviewed Jan 11, 2021
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool I think this looks right, one little comment but overall I'm happy.

Have you verified that this patch lets you do what you need to do?

@edwin0cheng
Copy link
Collaborator Author

Have you verified that this patch lets you do what you need to do?

Yes !

Screenshot from 2021-01-12 06-51-37

cmyr
cmyr approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@cmyr cmyr merged commit 291b121 into linebender:master Jan 12, 2021
@edwin0cheng edwin0cheng deleted the l10n-resource branch January 12, 2021 05:24
@cmyr cmyr mentioned this pull request Jun 30, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmyr cmyr cmyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edwin0cheng @cmyr