Add type parameters to generated lenses of generic structs. #1591
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives type inference something to grab hold of when chaining
LensExt methods or using WidgetExt::lens.
It removes the need for providing annoying and hard to work out type arguments to some method calls (removed one in Tabs).
This changes generated lenses from unit structs to field structs to hold PhantomDatas, so construction is more involved. It also adds generic parameters to these structs, so their types are changed.
A new method wasn't generated and used for the const fields in the targets impl, as lifetime parameters on const functions are unstable.