Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify druid & druid-shell Movement types #1655

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Unify druid & druid-shell Movement types #1655

merged 1 commit into from
Mar 19, 2021

Conversation

cmyr
Copy link
Member

@cmyr cmyr commented Mar 17, 2021

This deletes the old Movement enum in druid, and moves to using
druid-shell for everything.

more progress on #1652

@cmyr
Copy link
Member Author

cmyr commented Mar 18, 2021 •
edited
Loading

@lord I'd like to give you a chance to register any concerns, here?

edit: I meant to post this on #1653, which this is PR'd onto. 😬

@lord
Copy link
Contributor

lord commented Mar 18, 2021

Hahaa, was wondering why you wanted my feedback on adding this obviously useful function. I'll take a look there!

@cmyr cmyr force-pushed the unify-selection branch 2 times, most recently from cc20d1c to 0f910f0 Compare March 19, 2021 00:31
Base automatically changed from unify-selection to master March 19, 2021 01:30
@cmyr
Unify druid & druid-shell Movement types
8693192 
This deletes the old Movement enum in druid, and moves to using
druid-shell for everything.
@cmyr cmyr merged commit dde1587 into master Mar 19, 2021
@cmyr cmyr deleted the unify-movement branch March 19, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmyr @lord