Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SCROLLBAR_MIN_SIZE to env, and use Entry #1661

Merged
merged 12 commits into from
Mar 18, 2021
Merged

Add SCROLLBAR_MIN_SIZE to env, and use Entry #1661

merged 12 commits into from
Mar 18, 2021

Conversation

Cupnfish
Copy link
Contributor

No description provided.

maan2003
maan2003 reviewed Mar 18, 2021
View reviewed changes
Copy link
Collaborator

@maan2003 maan2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! just few nitpicks here and there

maan2003
maan2003 reviewed Mar 18, 2021
View reviewed changes
Copy link
Collaborator

@maan2003 maan2003 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more.

It makes sense to move the definition of SCROLLBAR_MIN_SIZE to module theme given that other scrollbar related things are there too. (looks like I can't comment there)

maan2003
maan2003 approved these changes Mar 18, 2021
View reviewed changes
Copy link
Collaborator

@maan2003 maan2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@maan2003 maan2003 merged commit fa156d7 into linebender:master Mar 18, 2021
richard-uk1 pushed a commit to richard-uk1/druid that referenced this pull request Apr 6, 2021
@Cupnfish @maan2003 @richard-uk1
Add SCROLLBAR_MIN_SIZE to env, and use Entry (linebender#1661)
cf17971 
* Add SCROLLBAR_MIN_SIZE to env, and  use Entry

* cargo fmt

* Update druid/src/scroll_component.rs

Co-authored-by: Manmeet Maan <[email protected]>

* Update druid/src/env.rs

Co-authored-by: Manmeet Maan <[email protected]>

* Update druid/src/env.rs

Co-authored-by: Manmeet Maan <[email protected]>

* Some adjustments

* Move SCROLLBAR_MIN_SIZE to module theme

* fmt

Co-authored-by: Manmeet Maan <[email protected]>

* cargo fmt

* cargo fmt

* fmt

* Update theme.rs

Co-authored-by: Downtime <[email protected]>
Co-authored-by: Manmeet Maan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maan2003 maan2003 maan2003 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cupnfish @maan2003