Correctly clip the TextBox #1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By adjusting only the x component of the size before turning it into a rectangle, the right side of the rectangle gets moved, which allowed the text to peak out on the right side. Inset already seems to do what subtracting the border width there was possibly intended to do, so just using the unadjusted size and then later insetting, resolves the problem entirely.
|
cool, I think this was a relic of an earlier version, where the padding was calculated and applied manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adjusting only the x component of the size before turning it into a rectangle, the right side of the rectangle gets moved to the left, which allowed the text to peak out on the right side. Inset already seems to do what subtracting the border width there was possibly intended to do, so just using the unadjusted size and then later insetting, resolves the problem entirely.
Here for reference the bug that this resolves: