Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

druid: update usvg #1802

Merged
merged 1 commit into from
May 24, 2021
Merged

druid: update usvg #1802

merged 1 commit into from
May 24, 2021

Conversation

r-ml
Copy link
Contributor

@r-ml r-ml commented May 22, 2021

Update usvg dependency from 0.12 to 0.14

Apparently no changes are required?
Builds fine and the example also works fine.

The main advantange of this change is that druid-shell depends on kurbo 0.8.1 and usvg 0.12 depends on kurbo 0.7.1,
therefore enabling the svg feature adds another kurbo crate to the dependency tree.
Updating to usvg 0.14 fixes this.

Update usvg dependency from 0.12 to 0.14
Copy link
Collaborator

@maan2003 maan2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@maan2003 maan2003 added the S-ready PR is ready to merge label May 23, 2021
@cmyr
Copy link
Member

cmyr commented May 24, 2021

Thanks!

@cmyr cmyr merged commit 2d1bed1 into linebender:master May 24, 2021
@josh-audio
Copy link
Collaborator

Ah, you beat me to it. Just did a quick smoke test with some SVGs locally and I don't see any regressions 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-ready PR is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants