-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid undefined behaviour in GTK animation frames #1832
Avoid undefined behaviour in GTK animation frames #1832
Conversation
Before merging, someone else please confirm that this code works. I currently cannot compile druid (AGAIN!!!! FFS rust how is this even possible. How can it never just WORK). This is copied straight out of my gtk4 code which did work. |
Both examples are working fine.
sounds horrible 😬 I believe this only affects druid-shell because druid doesn't let you request animation frame when painting (at type level!) CI is red due to new clippy lints (in 1.53)
I would love to know why. if you are bellow rustc 1.51 then it can solved by commenting out the const generic data impl for array |
No!!! because we base the whole cycle druid lifecycle on GTK draw events, including update. This is the only real option, since there isnt many other events this could be put into.
no I tried all channels. I didnt have much time today, I will try to reinstall rust all together. That didnt fix things last time, but it might now 🤷 |
rebasing should solve the CI issues now |
8f19c31
to
5203cd7
Compare
CI seems fixed 👍 |
welp, as github seems to have broken itself, CI fails. I tested the new code and works as before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Both animation and textbox examples are working
Requestion an animation frame is and always has been undefined behaviour.
This is not documented ANYWHERE besides the brains of whoever coded this.
See https://gitlab.gnome.org/GNOME/gtk/-/issues/3703.