Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wayland: cleanup popup implementation refactor. #2071

Merged
merged 1 commit into from
Dec 5, 2021

Conversation

james-lawrence
Copy link
Contributor

@james-lawrence james-lawrence commented Dec 4, 2021

only piece I have left at this point is the screen implementation which i need to make some improvements to before I open a PR it.

after that I'll do a rebase against master for the wayland branch. I think at that point it'll be close enough to mainline. PRs after the screen stuff should be minor enhancements, bug fixes (I have 1 or 2 things I might fix), or code cleanup.

still a few small odds an ends to make it feature complete (but i havent needed them so... here we are. =)).

  • bunch of the window builder API stuff needs to be wired up, titles, resizable, etc. these are small though and should be easily implemented as needed.
  • tooltips, and modal window levels need to be implemented. but they should be identical to the dropdowns with a different positioning configuration.
  • menus/dialog stuff. these can be shared with x11 i think?
  • keymapping issues (copy/paste not generating the correct keystroke of x11/wayland).

should I create issues for these things?

@james-lawrence james-lawrence changed the title wayland: cleanup popup implementation. wayland: cleanup popup implementation refactor. Dec 4, 2021
@james-lawrence james-lawrence force-pushed the wayland-popup-refactor branch 3 times, most recently from 17c9458 to 0afedd0 Compare December 4, 2021 11:43
- bunch of other misc cleanups
@maan2003
Copy link
Collaborator

maan2003 commented Dec 4, 2021

I also think this is ready to merge into master! It is pretty close to the x11 backend.

bunch of the window builder API stuff needs to be wired up, titles, resizable, etc. these are small though and should be easily implemented as needed.

yes should create an issue with missing shell/wayland labels

tooltips, and modal window levels need to be implemented. but they should be identical to the dropdowns with a different positioning configuration.

the positioning is exactly same 🤔

menus/dialog stuff. these can be shared with x11 i think?

we can just update the title/labels for #933 and #936

keymapping issues (copy/paste not generating the correct keystroke of x11/wayland).

Yes should create an issue. I think it is for all ctrl shortcuts

@james-lawrence
Copy link
Contributor Author

the positioning is exactly same

oh? then its really easy. ;)

@maan2003 maan2003 merged commit 25cac35 into linebender:wayland Dec 5, 2021
@james-lawrence james-lawrence deleted the wayland-popup-refactor branch December 6, 2021 01:06
james-lawrence added a commit to james-lawrence/druid that referenced this pull request Dec 6, 2021
- bunch of other misc cleanups
james-lawrence added a commit to james-lawrence/druid that referenced this pull request Dec 7, 2021
- bunch of other misc cleanups
maan2003 pushed a commit that referenced this pull request Jan 7, 2022
- bunch of other misc cleanups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants