-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement RadioGroup::{row,column,for_axis} to allow layout customization #2157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I'd be inclined to copy the Flex
naming for consistency, even if it is a breaking change. (e.g. RadioGroup::column
, RadioGroup::row
, and RadioGroup::for_axis
) What do you think about that?
Sure thing! I'll get on it this weekend :) |
Done! please take a look :) |
Looks great, thanks! We'll definitely want a changelog entry too (which I can do today if you don't have time). (Note that the links in the changelog aren't automatic; they're all defined at the bottom) |
Done, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience! I have to wait for CI to finish, and then I'll merge.
Trivial change to allow the user to set the Axis on which Radio's are laid out. Breaking change in that
RadioGroup::new
is nowRadioGroup::column
.Builder methods
column()
,row()
,for_axis()
are consistent with theFlex
widget.