Update to latest x11rb #2231
Merged
Update to latest x11rb #2231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only necessary change was in error handling: X11Error now contains more information about the request that caused the error. Namely, the name of its X11 extension is saved in an Option<String> and this is not Copy, so we need to .clone(). Signed-off-by: Uli Schlachter <[email protected]>
x11rb was split into two crates, x11rb and x11rb-protocol. This is pretty transparent for us except that x11rb::resource_manager::Database is now a re-export of x11rb_protocol::resource_manager::Database and does not have a new_from_default() associated method. Thus, we have to switch to x11rb::resource_manager::new_from_default() for the same functionality. Signed-off-by: Uli Schlachter <[email protected]>
maan2003
approved these changes
Jul 24, 2022
xarvic
pushed a commit
to xarvic/druid
that referenced
this pull request
Jul 29, 2022
* Update to x11rb 0.9.0 The only necessary change was in error handling: X11Error now contains more information about the request that caused the error. Namely, the name of its X11 extension is saved in an Option<String> and this is not Copy, so we need to .clone(). Signed-off-by: Uli Schlachter <[email protected]> * Update to x11rb 0.10 x11rb was split into two crates, x11rb and x11rb-protocol. This is pretty transparent for us except that x11rb::resource_manager::Database is now a re-export of x11rb_protocol::resource_manager::Database and does not have a new_from_default() associated method. Thus, we have to switch to x11rb::resource_manager::new_from_default() for the same functionality. Signed-off-by: Uli Schlachter <[email protected]>
xarvic
pushed a commit
to xarvic/druid
that referenced
this pull request
Jul 29, 2022
* Update to x11rb 0.9.0 The only necessary change was in error handling: X11Error now contains more information about the request that caused the error. Namely, the name of its X11 extension is saved in an Option<String> and this is not Copy, so we need to .clone(). Signed-off-by: Uli Schlachter <[email protected]> * Update to x11rb 0.10 x11rb was split into two crates, x11rb and x11rb-protocol. This is pretty transparent for us except that x11rb::resource_manager::Database is now a re-export of x11rb_protocol::resource_manager::Database and does not have a new_from_default() associated method. Thus, we have to switch to x11rb::resource_manager::new_from_default() for the same functionality. Signed-off-by: Uli Schlachter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates to the latest version of x11rb, getting rid of one old version of nix in the dependency tree.
While doing this, I noticed a comment referring to an x11rb issue that was already fixed two years ago and released in v0.7.0. Thus, the x11rb version you are using should already provide everything that is needed. CC @jneem FYI