Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various documentation-related fixes #2301

Merged
merged 6 commits into from
Jan 12, 2023
Merged

Conversation

PoignardAzur
Copy link
Collaborator

@PoignardAzur PoignardAzur commented Dec 7, 2022

Move and expand doc on hot and active status.
Document crate options.
Add discontinuation notice.
Rewrite Druid book.
Remove crochet stuff.
Fix typos.
Fix broken link.
Fix outdated doc links.
Fix examples/readme.md.

Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase this on master and resolve the conflicting druid/src/contexts.rs file.

I reviewed the other files and generally it looks like a good set of updates.

Thanks for taking the time!

@xStrom xStrom added docs concerns documentation S-waiting-on-author waits for changes from the submitter labels Jan 4, 2023
@PoignardAzur
Copy link
Collaborator Author

Sorry, haven't had too much bandwidth lately. I'll try to fix the PR this weekend.

@xStrom
Copy link
Member

xStrom commented Jan 6, 2023

No worries, I'm aware as you know 🙂 Whenever you find it reasonable.

Move and expand doc on hot and active status.
Document crate options.
Add discontinuation notice.
Remove crochet stuff.
Fix typos.
Fix broken link.
Fix outdated doc links.
Fix examples/readme.md.
@PoignardAzur
Copy link
Collaborator Author

Alright, I've rebased and applied some of your suggestions.

Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, I think it's good to merge! 🙂

@xStrom xStrom removed the S-waiting-on-author waits for changes from the submitter label Jan 10, 2023
@xStrom xStrom merged commit 23963d3 into linebender:master Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs concerns documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants