Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for strikethrough formatting on text. #299

Merged
merged 7 commits into from
Sep 6, 2020
Merged

Add support for strikethrough formatting on text. #299

merged 7 commits into from
Sep 6, 2020

Conversation

smmalis37
Copy link
Collaborator

@smmalis37 smmalis37 commented Sep 5, 2020

Made by basically just copying underline. Just like underline this does not have any support for formatting the strikethrough itself, although the underlying apis support it. I do not have access to a mac to test the coregraphics implementation (nor have I ever written mac code before), however the d2d implementation appears to work on my Win 10 box. This will need a snapshots update.

@smmalis37
Copy link
Collaborator Author

Whoops, I thought one of the files I was editing was piets, its actually core-graphics (vscode just lets you edit source of downloaded crates, fun). So that implementation won't work at the moment. Investigating what's needed.

@smmalis37
Copy link
Collaborator Author

smmalis37 commented Sep 5, 2020

Blocked on figuring out what to do with coregraphics. Turns out it doesn't seem to support strikethrough, so we might have to do it manually.

@smmalis37
Copy link
Collaborator Author

From Zulip:

Raph Levien: The best path forward might be to stub out the Apple implementation and open an issue to add it.

I'm fine with that if the maintainers are.

@smmalis37 smmalis37 marked this pull request as ready for review September 5, 2020 21:47
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'm happy to have this go in as-is; at some point I'd like to think more about a better API for "text decorations" but this is totally reasonable for now.

We'll need an issue that this needs implementation on macOS and cairo.

@cmyr cmyr merged commit 17180ac into linebender:master Sep 6, 2020
@smmalis37 smmalis37 deleted the strikethrough branch September 6, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants