-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for strikethrough formatting on text. #299
Conversation
Whoops, I thought one of the files I was editing was piets, its actually core-graphics (vscode just lets you edit source of downloaded crates, fun). So that implementation won't work at the moment. Investigating what's needed. |
Blocked on figuring out what to do with coregraphics. Turns out it doesn't seem to support strikethrough, so we might have to do it manually. |
From Zulip:
I'm fine with that if the maintainers are. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I'm happy to have this go in as-is; at some point I'd like to think more about a better API for "text decorations" but this is totally reasonable for now.
We'll need an issue that this needs implementation on macOS and cairo.
Made by basically just copying underline. Just like underline this does not have any support for formatting the strikethrough itself, although the underlying apis support it.
I do not have access to a mac to test the coregraphics implementation (nor have I ever written mac code before), however the d2d implementation appears to work on my Win 10 box. This will need a snapshots update.