-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for parsing CSS variables #28
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Tin Švagelj <[email protected]>
Signed-off-by: Tin Švagelj <[email protected]>
Signed-off-by: Tin Švagelj <[email protected]>
This reverts commit cc38766.
Should I actually add anything besides just bare It feels like adding support for Browsers store the whole AST and then resolve variables later, but the idea of svgtypes is to return the simplest uniform representation which doesn't work when variables are used. Looking at it from resvg perspective, it has some state with current variable values and it could resolve variables. But |
- Document VariableFunction fields. Signed-off-by: Tin Švagelj <[email protected]>
Sorry, but I would not have time reviewing your PR anytime soon. |
That's alright, it can wait, not sure I'll finish it anytime soon either. 😄
Took another look at the specification and you're right, CSS variables are only supported by browser implementation of SVG DOM because it's treated as HTML. However, having a way to modify values like |
Adds support for parsing CSS Variables Level 1.
This PR is a prerequisite for resvg#821.