Set font-family to Font Awesome 6 when using external FA
#576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to the latest dependency upgrade with commit c0d29ff
thinkh
added
type: bug
✅ Deploy Preview for lineupjs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
make sense, do you know whether there is a fontawesome variable available which we could use to avoid that in the future? |
|
Good idea! There is a variable for it. I can change it next time I'm at a computer again or you do it quickly. https://github.com/FortAwesome/Font-Awesome/blob/6.x/scss/_variables.scss#L6 |
|
@sgratzl I changed our SCSS to use the Font Awesome variables. Please have a look again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prerequisites:
Summary
The Font Awesome dependency has been updated from version 5 to version 6 with commit c0d29ff. However, the font-family has not been updated which results in broken icons. Using the the correct font family name fixes the icons.
Please note that the custom lu-font is still using/set to
Font Awesome 5.